Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed typings when using executeSignatureHelpProvider #7

Closed
wants to merge 3 commits into from
Closed

Fixed typings when using executeSignatureHelpProvider #7

wants to merge 3 commits into from

Conversation

DominicVonk
Copy link
Contributor

No description provided.

@DominicVonk DominicVonk mentioned this pull request Jul 29, 2020
Closed
@robertgr991 robertgr991 changed the base branch from dev to master July 29, 2020 16:24
@robertgr991 robertgr991 changed the base branch from master to dev July 29, 2020 16:24
@robertgr991
Copy link
Owner

Great, somehow i miseed the parameters prop of signature, can you make a new pull request to the master branch only with the the changes highlighted in this request and without the version? Thanks

@DominicVonk
Copy link
Contributor Author

Sure, I will push it right now.

I sent you email for the test files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DominicVonk @robertgr991