Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apple vision #1

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Apple vision #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f89ad13
Remove GLKit dependecy
wcandillon Mar 14, 2024
abaf9a7
Remove UIScreen for visionOS
robertherber Mar 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions example/ios/Podfile.lock
View file
Open in desktop
Expand Up @@ -335,7 +335,7 @@ PODS:
- RCTTypeSafety
- React-Core
- ReactCommon/turbomodule/core
- react-native-skia (0.1.0-development):
- react-native-skia (1.0.2):
- RCT-Folly (= 2021.07.22.00)
- React
- React-callinvoker
Expand Down Expand Up @@ -642,7 +642,7 @@ SPEC CHECKSUMS:
React-jsinspector: 9885f6f94d231b95a739ef7bb50536fb87ce7539
React-logger: 3f8ebad1be1bf3299d1ab6d7f971802d7395c7ef
react-native-safe-area-context: dfe5aa13bee37a0c7e8059d14f72ffc076d120e9
react-native-skia: 3f6a881e3d923bb6fe2f0d0e3a4d459ac50f3614
react-native-skia: 92ffbebe351bb47a0961a9c7b9d05fdf69aca153
React-perflogger: 2d505bbe298e3b7bacdd9e542b15535be07220f6
React-RCTActionSheet: 0e96e4560bd733c9b37efbf68f5b1a47615892fb
React-RCTAnimation: fd138e26f120371c87e406745a27535e2c8a04ef
Expand Down
4 changes: 4 additions & 0 deletions package/ios/RNSkia-iOS/RNSkiOSPlatformContext.h
View file
Open in desktop
Expand Up @@ -33,7 +33,11 @@ class RNSkiOSPlatformContext : public RNSkPlatformContext {
jsi::Runtime *runtime, RCTBridge *bridge,
std::shared_ptr<facebook::react::CallInvoker> jsCallInvoker)
: RNSkPlatformContext(runtime, jsCallInvoker,
#if TARGET_OS_VISION
3.0) {
#else
[[UIScreen mainScreen] scale]) {
#endif

// We need to make sure we invalidate when modules are freed
CFNotificationCenterAddObserver(
Expand Down
4 changes: 2 additions & 2 deletions package/react-native-skia.podspec
View file
Open in desktop
Expand Up @@ -17,7 +17,7 @@ Pod::Spec.new do |s|
# optional - use expanded license entry instead:
# s.license = { :type => "MIT", :file => "LICENSE" }
s.authors = { "Your Name" => "yourname@email.com" }
s.platforms = { :ios => "13.0" }
s.platforms = { :ios => "13.0", :visionos => "1.0" }
s.source = { :git => "https://github.com/shopify/react-native-skia/react-native-skia.git", :tag => "#{s.version}" }

s.requires_arc = true
Expand All @@ -28,7 +28,7 @@ Pod::Spec.new do |s|
"HEADER_SEARCH_PATHS" => '"$(PODS_TARGET_SRCROOT)/cpp/"/**'
}

s.frameworks = 'GLKit', 'MetalKit'
s.frameworks = 'MetalKit'

s.ios.vendored_frameworks = [
'libs/ios/libskia.xcframework',
Expand Down