JSON API #19
Merged
JSON API #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated description.
Added screen shot of login page.
Also corrected issue in JsonLogin where `response_object` was called on `self` (shouldn't!) Added `Content-Type` headers where they were previously missing.
Also fixed issue in users.UserSession.create_user_session() where **kwargs was missing (appeared to have issue with @classmethod decorator?)
Removed JSON API todo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes include:
config.py_logout_user()inlogin.pyfor handling logging users out (via destroying session cookies andUserSessionin NDB datastore.HTTP/1.1 400 Bad Requesterror handler inlogin.pyjson_object()function toUserclass inusers.py; will return a publicly displayable User object (i.e. what to return in JSON requests)._login.jsonviaJsonLoginwill: return information about a logged in user; log out a user; log in a user._login/create.jsonviaJsonLoginCreatewill: create a new user._login/activate.jsonviaJsonLoginAcivatewill: activate user accounts (email verification)_login/password/change.jsonviaJsonLoginPasswordChangewill: change the logged in user's password._login/password/forgot.jsonviaJsonLoginPasswordForgotwill: send a password recovery email._login/password/reset.jsonviaJsonLoginPasswordResetwill: reset a user's password (and verify a token is valid).Closes #3; Closes #18