Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webpack 4 support #47

Closed
attilapuskas opened this issue Oct 8, 2018 · 3 comments
Closed

Webpack 4 support #47

attilapuskas opened this issue Oct 8, 2018 · 3 comments

Comments

@attilapuskas
Copy link

attilapuskas commented Oct 8, 2018

We have noticed that with webpack 4 there is a DeprecationWarning for the plugin.

DeprecationWarning: Tapable.plugin is deprecated. Use new API on ``.hooks`` instead`
`at WebpackBundleSizeAnalyzerPlugin.apply (.\node_modules\webpack-bundle-size-analyzer\build\src\plugin.js:15:18)

According to that comment the changes should be done here.

@robertknight
Copy link
Owner

Thank-you for the report and the discussion link. I'm not actively using webpack for work at the moment, so I can't promise when I'll get to this. I will take a look at any PRs that are submitted for it.

@spiltcoffee
Copy link

@robertknight pretty easy fix, just changed stats.plugin('done') to stats.hooks.done.tap()

Confirmed it worked on my own Webpack 4 project.

@spiltcoffee
Copy link

@robertknight any word on #48 being merged?

robertknight added a commit that referenced this issue Nov 16, 2018
Updated Webpack Plugin to be compatible with Webpack 4 (fixes #47)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants