Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: string lengths #450

Merged
merged 1 commit into from
Nov 25, 2022
Merged

fix: string lengths #450

merged 1 commit into from
Nov 25, 2022

Conversation

stevenh
Copy link
Collaborator

@stevenh stevenh commented Nov 25, 2022

Fix string lengths for strings containing code points which require a Surrogate pair encoding in utf16.

Fixes #388

@stevenh stevenh force-pushed the fix/string-length branch 2 times, most recently from 7807497 to cda9910 Compare November 25, 2022 21:01
Fix string lengths for strings containing code points which require a
Surrogate pair encoding in utf16.

Fixes #388
@stevenh stevenh marked this pull request as ready for review November 25, 2022 21:34
@stevenh stevenh merged commit 4c46316 into master Nov 25, 2022
@stevenh stevenh deleted the fix/string-length branch November 25, 2022 21:35
sg3des pushed a commit to sg3des/otto that referenced this pull request Jul 17, 2023
Fix string lengths for strings containing code points which require a
Surrogate pair encoding in utf16.

Fixes robertkrimen#388
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Emoji length is different in browsers/nodejs and otto
1 participant