fix!: date underflow / overflow and utc #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use time.UnixMilli instead of UnixNano for time calculations to avoid underflow / overflow issues. BREAKING CHANGE: Use a GMT fixed time zone for UTC to mimic toUTCString behaviour of Javascript which outputs in GMT not UTC. Fixes #302
stevenh
force-pushed
the
fix/date-overflow
branch
from
cc9fdc0
to
1c891d3
Compare
sg3des
pushed a commit
to sg3des/otto
that referenced
this pull request
Jul 17, 2023
Use time.UnixMilli instead of UnixNano for time calculations to avoid underflow / overflow issues. BREAKING CHANGE: Use a GMT fixed time zone for UTC to mimic toUTCString behaviour of Javascript which outputs in GMT not UTC. Fixes robertkrimen#302
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use time.UnixMilli instead of UnixNano for time calculations to avoid underflow / overflow issues.
BREAKING CHANGE: Use a GMT fixed time zone for UTC to mimic toUTCString behaviour of Javascript which outputs in GMT not UTC.
Fixes #302