Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: number locale support #472

Merged
merged 1 commit into from
Nov 29, 2022
Merged

fix: number locale support #472

merged 1 commit into from
Nov 29, 2022

Conversation

stevenh
Copy link
Collaborator

@stevenh stevenh commented Nov 29, 2022

Add support for Number.toLocaleString() which was previously just using toString.

Default locale is: en-US

Fixes #285

Add support for Number.toLocaleString() which was previously just using
toString.

Default locale is: en-US

Fixes #285
@stevenh stevenh merged commit 7de4257 into master Nov 29, 2022
@stevenh stevenh deleted the fix/number-locale branch November 29, 2022 12:57
sg3des pushed a commit to sg3des/otto that referenced this pull request Jul 17, 2023
Add support for Number.toLocaleString() which was previously just using
toString.

Default locale is: en-US

Fixes robertkrimen#285
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect Implementation of Number.toLocaleString
1 participant