ci: fix lint failures #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix lint failures introduced by new 1.53 linters * Remove naked returns * Accept times using local time where intended * Allow unused parameter for now on call method * Disable depguard which just seems to be noise Also: * Correct typo so we use the specified golangci-lint version in CI.
stevenh
force-pushed
the
ci/fix-new-linters
branch
from
a4043ba
to
45d2168
Compare
sg3des
pushed a commit
to sg3des/otto
that referenced
this pull request
Jul 17, 2023
Fix lint failures introduced by new 1.53 linters * Remove naked returns * Accept times using local time where intended * Allow unused parameter for now on call method * Disable depguard which just seems to be noise Also: * Correct typo so we use the specified golangci-lint version in CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix lint failures introduced by new 1.53 linters
Also: