Ramd::packages can install from GitHub #8
Conversation
|
Can you re-run document? |
| if (is_github_package(name)) { | ||
| name <- strsplit("robertzk/Ramd", "/")[[1]][[2]] | ||
| } | ||
| require(name, character.only = TRUE) |
There was a problem hiding this comment.
Can you check in utils::installed.packages instead? A function with this name shouldn't be actually loading the package into memory.
|
nice! |
| #' @examples | ||
| #' \dontrun{ | ||
| #' load_package('glmnet') | ||
| #" load_package("glmnet") |
There was a problem hiding this comment.
wrong quote on the left hand side
| if (!require(name, character.only = TRUE)) | ||
| stop(paste('Package', name, 'not found')) | ||
| load_package <- function(name, verbose = FALSE) { | ||
| if (is.list(name)) { |
There was a problem hiding this comment.
This method is too long now. Can you split it up?
There was a problem hiding this comment.
You can replace this whole section with:
metadata <- name[-1]
name <- name[[1]]and then below replace
if (!is.null(metadata)) {
do.call(devtools::install_github, c(name, metadata))
}with
if (length(metadata)) {
do.call(devtools::install_github, c(list(name), metadata))
}
| # extract 0.3 from robertzk/Ramd@v0.3 | ||
| name <- strsplit(name, "@")[[1]][[2]] | ||
| if (grepl("v", name, fixed = TRUE)) { | ||
| name <- strsplit(name, "v")[[1]][[2]] |
There was a problem hiding this comment.
What if the author name has a v? This is terrible. You should use @v at least.
There was a problem hiding this comment.
Ouch... and unnecessary.
It is only separating everything after the @, so it would not include the author. Added some tests to prove that.
|
|
||
| if (is_github_package(name)) { | ||
| remote <- "GitHub" | ||
| install_from_github(name, metadata, remote, verbose) |
There was a problem hiding this comment.
Can you remove the remote parameter? That should be hardcoded into the install_from_github method.
There was a problem hiding this comment.
Seemed not DRY to me to duplicate it both here and in the method itself. You need remote outside to work for package not found on line 35.
Another option is to include the sub-functions within the load_package function so they can access remote as a global (without needing to be passed as a parameter), but I don't really like that as a style and it will lead to triply nested functions.
Thoughts?
|
Thanks! |
Ramd::packages can install from GitHub
No description provided.