feat(#97): implement readonly public api #109
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robherley
reviewed
Sep 21, 2023
Co-authored-by: Rob Herley <robherley@github.com>
Co-authored-by: Rob Herley <robherley@github.com>
Co-authored-by: Rob Herley <robherley@github.com>
Co-authored-by: Rob Herley <robherley@github.com>
|
Just need to update the other branch with the listing page, which combines both the feed method with the name and description - to include the tweaks here. |
robherley
reviewed
Sep 23, 2023
|
I do still want to look at this, and get it all sorted and closed off. Just busy at the moment! :) |
|
Handled the lint issues, as well as the various recommendations. Apologies it took so long - we may need to handle a merge conflict due to extending from the feed branch but deleting it afterwards. But that's ok |
|
Hey Rob, just had a glance over this to see if I missed anything (I did 😅) - I hope that it passes everything, I know it has been slow going, I appreciate the patience but the process has taught me a lot regarding what is recommended and preferred. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 1 of the PR to implement the API. Pt. 2 will come in once name/desc is merged