-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(#97): implement readonly public api #109
Conversation
Co-authored-by: Rob Herley <robherley@github.com>
Co-authored-by: Rob Herley <robherley@github.com>
Co-authored-by: Rob Herley <robherley@github.com>
Co-authored-by: Rob Herley <robherley@github.com>
Just need to update the other branch with the listing page, which combines both the feed method with the name and description - to include the tweaks here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few small comments, then we should be good to go!
I do still want to look at this, and get it all sorted and closed off. Just busy at the moment! :) |
Handled the lint issues, as well as the various recommendations. Apologies it took so long - we may need to handle a merge conflict due to extending from the feed branch but deleting it afterwards. But that's ok |
Hey Rob, just had a glance over this to see if I missed anything (I did 😅) - I hope that it passes everything, I know it has been slow going, I appreciate the patience but the process has taught me a lot regarding what is recommended and preferred. |
Part 1 of the PR to implement the API. Pt. 2 will come in once name/desc is merged