Make 'container' element follow 'overlay' rather than being nested within it #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in it. Styling adjusted accordingly.
Holf
commented
Feb 17, 2024
|
This looks great @Holf, thanks a lot! I need a bit of time (couple of weeks maximum) to give this a review and merge it — I'll get to it as soon as I can. Sorry! In case you're in a rush, you should (I think) be able to already use this in your projects (assuming you're using npm or similar) by switching the dependency to: - "svelte-micromodal": "^0.0.8"
+ "svelte-micromodal": "Holf/svelte-micromodal#6-make-overlay-and-container-peer-elements" |
|
Cool, and no rush at all. 👍 |
|
Thanks a lot for your contribution @Holf, and thanks for your patience! This looks great — releasing the new version to npm in a minute 🙂 |
|
Thank you, and no problem at all. Pleasure doing business with you. 😎 Do let me know if you spot any issues with it. |
|
I will! Likewise if you spot any other issues with the library 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a workaround for an issue in the underlying
micromodallibrary, present in version0.4.10.Upgrading from
0.4.8to0.4.10is desirable, as it fixes an issue where a click to dismiss the Overlay propagates through to any underlying clickable elements.This should fix #6.
Further notes on the changes are added as inline PR comments.