Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is an abstraction to complement to the existing
renderToMarkup
andrenderToSheetList
, specifically when using React, Preact or Inferno.Since
renderToMarkup
returns a string we currently have to usedangerouslySetInnerHTML
which prompts me to userenderToSheetList
but creating your own <style> tags is error prone.To adress this issue i've added a
renderToNodeList
method that returns actual stylesheets that can be injected directly into your Virtual DOMExample
Packages
fela-bindings
react-fela
preact-fela
inferno-fela
reason-fela
Versioning
Minor
Checklist
Quality Assurance
yarn run format
)yarn run lint
)yarn run test
)yarn run flow
)Changes
If one of the following checks doesn't make sense due to the type of PR, just check them.