Remove remotes #238
Remove remotes #238
Conversation
|
@azogue propose we merge this PR and make a seperate one to fix the tests, WDYT? |
|
Whatever you want. But if you can wait some hours, I can clone the branch, fix the tests, make a PR to |
|
OK sounds good! |
* Remove remote-platform related * Complete ZLL sensor tests: - Setup binary sensor, adds 1 full ZLL sensor from bridge 1 - Check generated entity state and attrs - Check add_to_hass logic - Check behavior for changes in presence or temperature, cover strange SML logic around the "changed" attribute - Check discovery and setup of a new sensor in bridge 2 - Cover the error when a data update is received before finishing entity setup - Check entity and schedule listener removal on HA stop
so there is only one setup pass here, the initial one with: ```yaml binary_sensor: - platform: huesensor scan_interval: 2 ``` (To achieve 1Hz freq, ommit the `scan_interval` value)
* No need for an integration test without remote, moving all to test_binary_sensor * Just 1 hass fixture with 2 bridges
Fix tests and add warning note on README
|
It is done :) You can review and merge #239 here, and then merge this in master. A doubt though, are you manually generating HACS versions or they are pushed automatically on each master commit? I say this to avoid release this until remotes is done, right? |
|
Wow, that was quick! |
|
Yes manually generating versions, although I am sure this can be automated..? |
|
I was asking because of #235. I also saw this bug I introduced and I fixed it in the POC I was working on, I forgot to make a PR like #235. About the HACS releases, I would do:
Sure thing, but it is also kind of dangerously |
Looks like a bad rebase you did there |
Codecov Report
@@ Coverage Diff @@
## master #238 +/- ##
==========================================
+ Coverage 96.52% 97.09% +0.56%
==========================================
Files 6 5 -1
Lines 317 241 -76
==========================================
- Hits 306 234 -72
+ Misses 11 7 -4
Continue to review full report at Codecov.
|
|
does this move now force people that want both the sensor, device_tracker and the remote to install both custom integrations, and hence have to install the data mananager and hue api response in both folders? must say I can't really follow now, since this was move was originally intended to diminish the sources needed, and now seems to cause an increase.. btw, in the readme there is a big warning for causing issues in the core system. Which imho is really an unnecessary disclaimer, since the issues mentioned are not caused by this custom integration, and happen without it all the same. sorry if I am misunderstanding, but hope this custom integration that was so rock solid and working beautifully independently from the issues in core HA, won't morph into absorbing these issues... really worried here. |
|
Well you can see the discussion that lead to this move. |
|
I'm a bit at loss as for the reasoning behind splitting off the remotes to another component, I must say |
|
As of quite some versions ago HA also started to support motion sensors. Actually the native support is very good |
No description provided.