This repository has been archived by the owner on Jul 23, 2021. It is now read-only.
Fix tests and add warning note on README #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove remote-platform related * Complete ZLL sensor tests: - Setup binary sensor, adds 1 full ZLL sensor from bridge 1 - Check generated entity state and attrs - Check add_to_hass logic - Check behavior for changes in presence or temperature, cover strange SML logic around the "changed" attribute - Check discovery and setup of a new sensor in bridge 2 - Cover the error when a data update is received before finishing entity setup - Check entity and schedule listener removal on HA stop
so there is only one setup pass here, the initial one with: ```yaml binary_sensor: - platform: huesensor scan_interval: 2 ``` (To achieve 1Hz freq, ommit the `scan_interval` value)
* No need for an integration test without remote, moving all to test_binary_sensor * Just 1 hass fixture with 2 bridges
Codecov Report
@@ Coverage Diff @@
## remove-remotes #239 +/- ##
=================================================
Coverage ? 96.69%
=================================================
Files ? 5
Lines ? 242
Branches ? 0
=================================================
Hits ? 234
Misses ? 8
Partials ? 0
Continue to review full report at Codecov.
|
|
LGTM, thanks! |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
remoteplatform related codecover strange SML logic around the "changed" attribute
Please @robmarkcole, feel free to fix the note in the readme, as I'm far from being a native and I'm never sure about my style :)