Skip to content

Commit

Permalink
normalize page views graph methods to contain pageviews ,one word
Browse files Browse the repository at this point in the history
  • Loading branch information
robmckinnon committed Aug 5, 2008
1 parent 67d58d3 commit 56e34d3
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 7 deletions.
4 changes: 2 additions & 2 deletions README
Original file line number Diff line number Diff line change
Expand Up @@ -75,10 +75,10 @@ The +pageviews+ method is doing this under the hood:

report = profile.pageviews_report(:from=>'2007-01-01', :to=>'2007-01-02')

report.page_views_total
report.pageviews_total
=> 24980

And under the hood, the +page_views_total+ method is actually calling:
And under the hood, the +pageviews_total+ method is actually calling:

report.pageviews_graph.sum_of_points
=> 24980
Expand Down
4 changes: 2 additions & 2 deletions README.rdoc
Original file line number Diff line number Diff line change
Expand Up @@ -75,10 +75,10 @@ The +pageviews+ method is doing this under the hood:

report = profile.pageviews_report(:from=>'2007-01-01', :to=>'2007-01-02')

report.page_views_total
report.pageviews_total
=> 24980

And under the hood, the +page_views_total+ method is actually calling:
And under the hood, the +pageviews_total+ method is actually calling:

report.pageviews_graph.sum_of_points
=> 24980
Expand Down
2 changes: 1 addition & 1 deletion lib/rugalytics/report.rb
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ def handle_graphs lines
end

graph = Graph.new name, graph_period, points, start_date, end_date
morph("#{name} graph", graph)
morph("#{name.sub(/page views/i,'pageviews')} graph", graph)
end
end

Expand Down
4 changes: 2 additions & 2 deletions spec/lib/rugalytics/report_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -151,8 +151,8 @@ def graph_correct expected_start, expected_end
Graph.should_receive(:new).with(@name, @period, [5360, 433], expected_start, expected_end).and_return graph

report = Report.new(@csv.join("\n"))
report.page_views_graph.should == graph
report.attribute_names.should == ['page_views_graph']
report.pageviews_graph.should == graph
report.attribute_names.should == ['pageviews_graph']
end

describe 'with source date format "Month Day, Year"' do
Expand Down

0 comments on commit 56e34d3

Please sign in to comment.