Improve error reporting format

Now it points location with character-level accuracy (instead of line-level).
robocomp · Jun 13, 2020 · 2459a4e · 2459a4e
1 parent c57289a
commit 2459a4e
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 6 deletions.
diff --git a/learnbot_dsl/learnbotCode/LearnBlock.py b/learnbot_dsl/learnbotCode/LearnBlock.py
@@ -923,16 +923,17 @@ def textCodeToPython(self, name_Client):
                 def formatError(error):
                     level = error['level']
                     message = error['message']
-                    start, end = error['span']
+                    start = error['from']
+                    end = error['to']
 
                     if (start == None and end == None):
                         spanMsg = "somewhere"
                     elif (end == None):
-                        spanMsg = f"from line {start}"
+                        spanMsg = f"from {start[0]}:{start[1]}"
                     elif (start == end):
-                        spanMsg = f"line {start}"
+                        spanMsg = f"at {start[0]}:{start[1]}"
                     else:
-                        spanMsg = f"lines {start}-{end}"
+                        spanMsg = f"from {start[0]}:{start[1]} to {end[0]}{end[1]}"
 
                     return f"{level}: {message} ({spanMsg})"
 

diff --git a/learnbot_dsl/learnbotCode/Parser.py b/learnbot_dsl/learnbotCode/Parser.py
@@ -882,7 +882,8 @@ def parserLearntBotCode(inputFile, outputFile, client_name):
         errors.append({
             'level': 'error',
             'message': "Parse error",
-            'span': (output.lineno, None),
+            'from': (output.lineno, output.col),
+            'to': None,
         })
 
         return None, errors
@@ -908,7 +909,8 @@ def parserLearntBotCodeFromCode(code, name_client):
         errors.append({
             'level': 'error',
             'message': "Parse error",
-            'span': (output.lineno, None),
+            'from': (output.lineno, output.col),
+            'to': None,
         })
 
         return None, errors