Skip to content

Fix return value when sv.Detections is empty - #430

Merged
SkalskiP merged 2 commits into
roboflow:developfrom
akashpambhar:fix-return-empty-detections
Oct 6, 2023
Merged

Fix return value when sv.Detections is empty#430
SkalskiP merged 2 commits into
roboflow:developfrom
akashpambhar:fix-return-empty-detections

Conversation

@akashpambhar

Copy link
Copy Markdown
Contributor

Description

Fixes #429. When sv.Detections is empty (len(detections) == 0) sv.ByteTrack returns np.array([], dtype=int)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

@CLAassistant

CLAassistant commented Oct 6, 2023

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello there, thank you for opening an PR ! 馃檹馃徎 The team was notified and they will get back to you asap.

@onuralpszr onuralpszr added enhancement New feature or request hacktoberfest Open for contributions during the annual Hacktoberfest event, aimed at encouraging open-source parti API:tracker labels Oct 6, 2023
@SkalskiP

SkalskiP commented Oct 6, 2023

Copy link
Copy Markdown
Collaborator

Hi @akashpambhar 馃憢馃徎! Thanks for the PR. 馃檹馃徎 Let me quickly test if everything works as expected.

Comment thread supervision/tracker/byte_tracker/core.py Outdated
@SkalskiP
SkalskiP self-requested a review October 6, 2023 22:03
@SkalskiP

SkalskiP commented Oct 6, 2023

Copy link
Copy Markdown
Collaborator

Tested! Now, we are ready to merge. 馃憤馃徎

@SkalskiP
SkalskiP merged commit c5c37e4 into roboflow:develop Oct 6, 2023
@onuralpszr onuralpszr added the hacktoberfest-accepted Contribute to the notion of open-source this October! label Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API:tracker enhancement New feature or request hacktoberfest Open for contributions during the annual Hacktoberfest event, aimed at encouraging open-source parti hacktoberfest-accepted Contribute to the notion of open-source this October!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix sv.ByteTrack.tracker_id return value when sv.Detections is empty

4 participants