Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RoboSherlockFragmentActivity #227

Closed
pikaboo opened this issue Sep 15, 2014 · 8 comments
Closed

RoboSherlockFragmentActivity #227

pikaboo opened this issue Sep 15, 2014 · 8 comments

Comments

@pikaboo
Copy link

pikaboo commented Sep 15, 2014

can you merge it to the current build so that people can use it too ?
It feels a bit weird to use the roboguice sherlock, because it is 2 years old, and you keep updating roboguice but not roboguice sherlock

@stephanenicolas
Copy link
Contributor

What do you mean exactly ?

@pikaboo
Copy link
Author

pikaboo commented Sep 15, 2014

@stephanenicolas
Copy link
Contributor

Sorry pikaboo, but can you be more clear. It may seem obvious to you, but
it's not to me.
Please make sentences and provide context.

FYI, we have spent the last months working on RG 3 and are starting some
exploratory work on RG 4. Personally, I do need a refresher about RG 2.0
issues of this kind.

2014-09-15 8:16 GMT-04:00 pikaboo notifications@github.com:

https://www.versioneye.com/java/com.github.rtyley:roboguice-sherlock/1.5


Reply to this email directly or view it on GitHub
#227 (comment).

@pikaboo
Copy link
Author

pikaboo commented Sep 15, 2014

I want to use ActionBarSherlock with Roboguice, there is no RoboSherlockFragmentActivity that supports the action bar, thus any calls to getActionBar() using roboguice result in NPE. I looked on google, and somebody wrote it in. Can you merge it? so I can write it into my base activity and use it ?

https://github.com/rtyley/roboguice-sherlock

@stephanenicolas
Copy link
Contributor

Ok. Thx for the details. Is there any PR to merge for us ? What do you mean
when you say : "I looked on google, and somebody wrote it in." ?

2014-09-15 8:34 GMT-04:00 pikaboo notifications@github.com:

I want to use ActionBarSherlock with Roboguice, there is no
RoboSherlockFragmentActivity that supports the action bar, thus any calls
to getActionBar() using roboguice result in NPE. I looked on google, and
somebody wrote it in. Can you merge it? so I can write it into my base
activity and use it ?

https://github.com/rtyley/roboguice-sherlock


Reply to this email directly or view it on GitHub
#227 (comment).

@emmby
Copy link
Contributor

emmby commented Sep 15, 2014

Good news! RoboSherlockFragmentActivity is already included in RoboGuice 3.
https://github.com/roboguice/roboguice/blob/master/roboguice/src/main/java/roboguice/activity/RoboSherlockFragmentActivity.java

We're in the final stages of releasing RG3, so you should be able to use it in your projects soon.

@emmby emmby closed this as completed Sep 15, 2014
@pikaboo
Copy link
Author

pikaboo commented Sep 15, 2014

ahh cool, when is RG3 coming out?

@stephanenicolas
Copy link
Contributor

Super soon.

2014-09-15 16:34 GMT-04:00 pikaboo notifications@github.com:

ahh cool, when is RG3 coming out?


Reply to this email directly or view it on GitHub
#227 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants