-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Avoid ClassNode construction for classes that do not get instrumented
According to https://asm.ow2.io/performance.html, using a ClassReader is a lot faster for reading basic class metadata than creating a ClassNode. This is because to create a ClassNode, every single byte of the class file needs to be visited, including method instructions. For ClassReader, a lot of the work is done lazily. Previously, a ClassNode object was constructed for every class loaded by SandboxClassLoaer, regardless of whether or not it was instrumented. Instead, use a ClassReader approach to determine whether or not a class needs to be instrumented, and then build the ClassNode if it needs to be instrumented. This should improve performance for larger tests that load a lot of non-Android classes. PiperOrigin-RevId: 351251828
- Loading branch information
Showing
11 changed files
with
108 additions
and
58 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
64 changes: 64 additions & 0 deletions
64
sandbox/src/main/java/org/robolectric/internal/bytecode/ClassDetails.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,64 @@ | ||
package org.robolectric.internal.bytecode; | ||
|
||
import java.lang.annotation.Annotation; | ||
import java.util.HashSet; | ||
import java.util.Set; | ||
import org.objectweb.asm.ClassReader; | ||
import org.objectweb.asm.ClassVisitor; | ||
import org.objectweb.asm.Opcodes; | ||
|
||
/** | ||
* A more lightweight variant of {@link MutableClass}. This lets you check for basic metadata like | ||
* class name, interfaces, and annotation info by wrapping a {@link ClassReader}, which is | ||
* significantly faster than a {@link org.objectweb.asm.tree.ClassNode} object. | ||
*/ | ||
public class ClassDetails { | ||
private final ClassReader classReader; | ||
private final String className; | ||
private Set<String> annotations; | ||
|
||
public ClassDetails(byte[] classBytes) { | ||
this.classReader = new ClassReader(classBytes); | ||
this.className = classReader.getClassName().replace('/', '.'); | ||
} | ||
|
||
public boolean isInterface() { | ||
return (classReader.getAccess() & Opcodes.ACC_INTERFACE) != 0; | ||
} | ||
|
||
public boolean isAnnotation() { | ||
return (classReader.getAccess() & Opcodes.ACC_ANNOTATION) != 0; | ||
} | ||
|
||
public String getName() { | ||
return className; | ||
} | ||
|
||
public boolean hasAnnotation(Class<? extends Annotation> annotationClass) { | ||
if (annotations == null) { | ||
this.annotations = new HashSet<>(); | ||
classReader.accept( | ||
new AnnotationVisitor(annotations), | ||
ClassReader.SKIP_CODE | ClassReader.SKIP_DEBUG | ClassReader.SKIP_FRAMES); | ||
} | ||
String internalName = "L" + annotationClass.getName().replace('.', '/') + ";"; | ||
return this.annotations.contains(internalName); | ||
} | ||
|
||
private static class AnnotationVisitor extends ClassVisitor { | ||
private final Set<String> annotations; | ||
|
||
public AnnotationVisitor(Set<String> annotations) { | ||
super(Opcodes.ASM9); | ||
this.annotations = annotations; | ||
} | ||
|
||
@Override | ||
public org.objectweb.asm.AnnotationVisitor visitAnnotation(String descriptor, boolean visible) { | ||
if (visible) { | ||
annotations.add(descriptor); | ||
} | ||
return null; | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters