OutOfMemoryError comes back when targeting android 31

[calvarez-ov]

Description

We had issue #2584.

We had this workaround for that issue, on every test tearDown:

        // https://github.com/robolectric/robolectric/issues/2584
        val windowData = Reflection.staticField("WINDOW_DATA").ofType(Any::class.java)
            .`in`(ShadowCursorWindow::class.java).get()
        val dataMap =
            Reflection.field("dataMap").ofType(MutableMap::class.java).`in`(windowData).get()
        dataMap.clear()

With robolectric 4.7.1, if we set sdk=31 in robolectric.properties, this workaround causes reflection exceptions when running tests.

I removed the workaround, and I have OutOfMemoryErrors once again.

Steps to Reproduce

See #2584

Robolectric & Android Version

• robolectric: 4.7.1
• compileSdkVersion: 31
• targetSdkVersion: 30
• robolectric.properties: sdk: 31

Note: with robolectric 4.7.1, if stay with sdk of 30 and keep the workaround, there aren't OutOfMemoryErrors
Not so sure about this statement. I need to double check.

[calvarez-ov]

If I make the following change the workaround, I still have OutOfMemoryErrors:

         // https://github.com/robolectric/robolectric/issues/2584
         val windowData = Reflection.staticField("WINDOW_DATA").ofType(Any::class.java)
-            .`in`(ShadowCursorWindow::class.java).get()
+            .`in`(ShadowLegacyCursorWindow::class.java).get()
         val dataMap =
             Reflection.field("dataMap").ofType(MutableMap::class.java).`in`(windowData).get()
         dataMap.clear()

[hoisie]

Can you add -XX:+HeapDumpOnOutOfMemoryError to your project's JVM flags? It would be good to track what is causing the OOM. You could either upload the hprof file or use VisualVM to analyze it.

Also what's the max heap size that is being used? I typically recommend -Xmx4096M.

[calvarez-ov]

I'll check those jvm flags in a moment.

I just wanted to also note here that I tried setting the following, and it didn't solve the problem:

     testOptions {
         unitTests {
             all {
                 ...
                 systemProperty 'robolectric.sqliteMode', "NATIVE"
             }
         }
     }

[calvarez-ov]

I had almost your settings, but in a comment:

#org.gradle.jvmargs=-Xmx4G -XX:+HeapDumpOnOutOfMemoryError

Our deveops person recommended to not specify them:

My recommendation would be to remove all the specific configurations (Xmx as you did) and to rely only on the memory of the container

But I'll uncomment it and try again

[calvarez-ov]

Ok, I found the config to enable these options:

 tasks.configureEach { theTask ->
     def taskName = theTask.name.toString()
     if (taskName =~ /test.*DebugUnitTest/) {
-        theTask.jvmArgs('-ea', '-noverify')
+        theTask.jvmArgs('-ea', '-noverify', '-Xmx4G', '-XX:+HeapDumpOnOutOfMemoryError')
     }
 }

I now have a 2G heap file! I'll check out VisualVM

[calvarez-ov]

[calvarez-ov]

[hoisie]

Can you search for Activity? When you see resources like that, it typically involves Activities that leak across tests.

[calvarez-ov]

For info, doing this at the end of each test makes the OutOfMemoryErrors go away:

Registries.NATIVE_THEME9_REGISTRY.clear()

[calvarez-ov]

I'll look for activites though

[calvarez-ov]

Possibly related: #5530

[hoisie]

Thanks for reporting this. Looking at this further, it does seem like the logic that frees themes does not seem to run in Android S:

https://github.com/robolectric/robolectric/blob/master/shadows/framework/src/main/java/org/robolectric/shadows/ShadowArscAssetManager10.java#L1585

This seems to be the logic for releasing themes now:

https://cs.android.com/android/platform/superproject/+/master:frameworks/base/core/java/android/content/res/AssetManager.java;l=1180-1184

This ends up calling nativeDestroy.

[hoisie]

Just pushed 4.7.2 which should hopefully contain a fix for this issue. Reopening for now. @calvarez-ov when you get a chance can you check if it worked?

[caarmen]

Yes, it works!

I updated to 4.7.2, removed my Registries.NATIVE_THEME9_REGISTRY.clear() workaround, and ran the test suite without any OutOfMemoryError.

Thanks so much! 🙏

(I'm calvarez-ov's evil twin)