Fix plan cache access. #2508
Closed
Fix plan cache access. #2508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ling get() and checking for null. Otherwise, since CALL_REAL_CODE_PLAN is only ever set to null, calculatePlan() is called over and over again for methods whose Plan is CALL_REAL_CODE_PLAN, causing a ~7x slowdown in test run time. There is probably some further clean up so CALL_REAL_CODE_PLAN is set to something non-null, but for now this fixes the performance regression.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fix performance regression is ShadowWrangler.methodInvoked().
Proposed Changes
Use containsKey() to check for entries in the Plan cache, instead of calling get() and checking for null. Otherwise, since CALL_REAL_CODE_PLAN is only ever set to null, calculatePlan() is called over and over again for methods whose Plan is CALL_REAL_CODE_PLAN, causing a ~7x slowdown in test run time.
There is probably some further clean up so CALL_REAL_CODE_PLAN is set to something non-null, but for now this fixes the performance regression.