Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kill FsFile et al. in favor of java.nio.file.Path #4265

Merged
merged 12 commits into from Dec 17, 2018
Merged

Kill FsFile et al. in favor of java.nio.file.Path #4265

merged 12 commits into from Dec 17, 2018

Conversation

xian
Copy link
Member

@xian xian commented Dec 4, 2018 •
edited

Fs and FsFile were semi-baked attempts at what Path does now, use that instead.

@xian xian added this to the 4.1 milestone Dec 4, 2018
@xian xian force-pushed the kill-fs-file branch 2 times, most recently from aee0380 to c053a30 Compare December 5, 2018 22:30
@xian xian added the cla: yes label Dec 5, 2018
@xian xian changed the title Kill FsFile and friends Kill FsFile et al. Dec 5, 2018
@xian xian changed the title Kill FsFile et al. Kill FsFile et al. in favor of java.nio.files.Path Dec 5, 2018
@xian xian changed the title Kill FsFile et al. in favor of java.nio.files.Path Kill FsFile et al. in favor of java.nio.file.Path Dec 5, 2018
@xian xian force-pushed the kill-fs-file branch 2 times, most recently from 2474f6c to f13d78a Compare December 6, 2018 00:49
@xian xian modified the milestones: 4.1, backlog Dec 12, 2018
@xian
java.nio.file.Path is buggy as hell.
5ffaf54 
Path#getFileName() returns trailing slash for directories inside zips.
@xian
Cache/reuse jar filesystems.
dde6253 
Use Fs.fromUrl() instead of Paths.get().
@xian xian modified the milestones: backlog, 4.2 Dec 14, 2018
@xian xian force-pushed the kill-fs-file branch 2 times, most recently from b2c03b7 to af1b9cb Compare December 14, 2018 22:47
@xian
Check/reset Thread.interrupted() after every test.
f6952d5 
If a test is interrupted, subsequent tests using subclasses of
AbstractInterruptibleChannel will fail with
java.nio.channels.ClosedByInterruptException, e.g. often when opening
jar files.

Check at the end of every test.
@xian xian merged commit e04e04c into master Dec 17, 2018
copybara-robolectric added a commit that referenced this pull request Dec 17, 2018
@copybara-robolectric
Merge pull request #4265 from robolectric:kill-fs-file
68e194a 
PiperOrigin-RevId: 225880485
@xian xian deleted the kill-fs-file branch January 13, 2019 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@xian