New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kill FsFile et al. in favor of java.nio.file.Path #4265
Merged
Merged
Commits on Dec 13, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 3c1a3e0 - Browse repository at this point
Copy the full SHA 3c1a3e0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3a40ba5 - Browse repository at this point
Copy the full SHA 3a40ba5View commit details -
Configuration menu - View commit details
-
Copy full SHA for d7a4955 - Browse repository at this point
Copy the full SHA d7a4955View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9463abe - Browse repository at this point
Copy the full SHA 9463abeView commit details -
Configuration menu - View commit details
-
Copy full SHA for c98523e - Browse repository at this point
Copy the full SHA c98523eView commit details -
Configuration menu - View commit details
-
Copy full SHA for d5d3963 - Browse repository at this point
Copy the full SHA d5d3963View commit details -
java.nio.file.Path is buggy as hell.
Path#getFileName() returns trailing slash for directories inside zips.
Configuration menu - View commit details
-
Copy full SHA for 5ffaf54 - Browse repository at this point
Copy the full SHA 5ffaf54View commit details
Commits on Dec 14, 2018
-
Configuration menu - View commit details
-
Copy full SHA for dde6253 - Browse repository at this point
Copy the full SHA dde6253View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2962abf - Browse repository at this point
Copy the full SHA 2962abfView commit details
Commits on Dec 15, 2018
-
Configuration menu - View commit details
-
Copy full SHA for a9f61e2 - Browse repository at this point
Copy the full SHA a9f61e2View commit details -
Check/reset Thread.interrupted() after every test.
If a test is interrupted, subsequent tests using subclasses of AbstractInterruptibleChannel will fail with java.nio.channels.ClosedByInterruptException, e.g. often when opening jar files. Check at the end of every test.
Configuration menu - View commit details
-
Copy full SHA for f6952d5 - Browse repository at this point
Copy the full SHA f6952d5View commit details
Commits on Dec 17, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 9cc4569 - Browse repository at this point
Copy the full SHA 9cc4569View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.