Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve AARs like the android plugins do (kind of). #4279

Merged
merged 8 commits into from
Dec 15, 2018
Merged

Conversation

xian
Copy link
Member

@xian xian commented Dec 10, 2018

No longer need scripts/install-dependencies.rb or mvn.

You'll want to do this locally wherever that script as been run:

( cd ~/.m2/repository && rm -rf androidx \
  && rm -rf com/android && rm -rf com/google/android )

@xian xian added this to the 4.1 milestone Dec 10, 2018
@xian
Copy link
Member Author

xian commented Dec 10, 2018

Blargh, this breaks IDE classpaths for AAR deps. Will investigate.

@xian xian modified the milestones: 4.1, backlog Dec 11, 2018
@xian xian added the cla: yes label Dec 15, 2018
copybara-robolectric pushed a commit that referenced this pull request Dec 15, 2018
Original change by copybara-piper@copybara-piper:copybara_Standalone-050BE78872E38479E12CA3B1DC1BA555_0:17938:citc on 2018/12/14 17:25:45.

Resolve AARs like the android plugins do (kind of). (PR#4279)

No longer need `scripts/install-dependencies.rb` or `mvn`.

You'll want to do this locally wherever that script as been run:
```sh
( cd ~/.m2/repository && rm -rf androidx \
  && rm -rf com/android && rm -rf com/google/android )
```

Pull Request: #4279

Commits:
----
f1572a0 - Christian Williams <christianw@google.com> - 2018-12-14T17:27:35-08:00
    Fix imports.

----
30f5aad - Christian Williams <christianw@google.com> - 2018-12-14T17:21:12-08:00
    Remove another mavenLocal() repo.

----
3541e50 - Christian Williams <christianw@google.com> - 2018-12-14T16:59:27-08:00
    Workaround for IntelliJ bug with identical library names.

----
d53cc24 - Christian Williams <christianw@google.com> - 2018-12-09T23:31:01-08:00
    compileOnly and testCompileOnly should be distinct or they screw up aar resolution.

----
8d2cc3c - Christian Williams <christianw@google.com> - 2018-12-09T22:54:25-08:00
    Fix transform scope.

----
e671a45 - Christian Williams <christianw@google.com> - 2018-12-09T21:43:11-08:00
    Kill some log noise.

----
9174e18 - Christian Williams <christianw@google.com> - 2018-12-09T21:40:20-08:00
    Fixes.

    Refer to stubs jar explicitly from integration test.

    Explicitly call prefetchSdks for projects in the build that don't have a
    robolectric-deps.properties injected.

----
10c9085 - Christian Williams <christianw@google.com> - 2018-12-09T21:28:25-08:00
    Resolve AARs like the android plugins do (kind of).

PiperOrigin-RevId: 225629873
@xian xian merged commit f1572a0 into master Dec 15, 2018
@xian xian deleted the resolve-aars branch December 16, 2018 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant