Fall back to Android's implementation of getResourcesForApplication #4969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-robolectric
force-pushed
the
piper_246042251
branch
4 times, most recently
from
5a2cfcb
to
5dd09fd
Compare
copybara-robolectric
force-pushed
the
piper_246042251
branch
3 times, most recently
from
2ec60ff
to
c2e93df
Compare
PackageManager.getResourcesForApplication can be used on an Android device to get the resources for a not-installed apk, but it only works for installed apks in robolectric. This falls back to the platform implementation for not-installed apks, while maintaining the existing functionality for installed apks. This change only affects the behavior in binary resource mode. In legacy resource mode, there should be no change in behavior. PiperOrigin-RevId: 248604936
copybara-robolectric
force-pushed
the
piper_246042251
branch
from
c2e93df
to
ba556d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fall back to Android's implementation of getResourcesForApplication
PackageManager.getResourcesForApplication can be used on an Android device
to get the resources for a not-installed apk, but it only works for
installed apks in robolectric.
This falls back to the platform implementation for not-installed apks,
while maintaining the existing functionality for installed apks.