Execute google-java-format-diff.py directly on CI machines #6268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
piper_361611243
branch
2 times, most recently
from
1ad722b
to
6b0dfae
Compare
hoisie
changed the title
copybara-service
bot
force-pushed
the
piper_361611243
branch
2 times, most recently
from
80a5518
to
d18a408
Compare
|
@hoisie maybe we also should keep the github action CI machine to the specific |
At the moment google-java-format-diff.py only works with Python2 and CI machines are starting to use Python3 by default as the 'python' binary. This defers to the script itself to select the appropriate python version. Also fix one google-java-format offender. PiperOrigin-RevId: 361611243
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Execute google-java-format-diff.py directly on CI machines
At the moment google-java-format-diff.py only works with Python2 and CI
machines are starting to use Python3 by default as the 'python' binary.
This defers to the script itself to select the appropriate python
version.
Also fix one google-java-format offender.