Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init color array for decode file descriptor #6272

Merged

Conversation

utzcoz
Copy link
Member

@utzcoz utzcoz commented Mar 9, 2021

It support init color array for decodeFileDescriptor. And it also clean up initColorArray method, and remove the variant needs reset.

Signed-off-by: utzcoz <utzcoz@outlook.com>
Signed-off-by: utzcoz <utzcoz@outlook.com>
Signed-off-by: utzcoz <utzcoz@outlook.com>
Signed-off-by: utzcoz <utzcoz@outlook.com>
@utzcoz
Copy link
Member Author

utzcoz commented Mar 9, 2021

@hoisie could you help to review this PR? Thanks. If #6268 merged, I will rebase it.

@hoisie
Copy link
Contributor

hoisie commented Mar 9, 2021

This is awesome, thanks. Much cleaner. It's nice not to have to create two BufferedImages (one for dimensions, one for colors).

@hoisie hoisie merged commit 17b1801 into robolectric:master Mar 9, 2021
@utzcoz utzcoz deleted the init-color-array-for-decodeFileDescriptor branch March 10, 2021 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants