Fix SQLiteDatabaseTest foreign key test to match Android behavior #6643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
piper_386770883
branch
from
bf093df
to
19467ec
Compare
SQLiteDatabaseTest.shouldThrowWhenForeignKeysConstraintIsViolated failed if run on a real Android. It expected that a foreign key exception be thrown. In real Android, however, no exception was thrown. Only a message is printed in logcat. Update the test to delete a row that has a reference to another table. This causes an exception in both real Android and Robolectric. Move this to a ctesque test to ensure fidelity with real Android. PiperOrigin-RevId: 386770883
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix SQLiteDatabaseTest foreign key test to match Android behavior
SQLiteDatabaseTest.shouldThrowWhenForeignKeysConstraintIsViolated failed if run
on a real Android. It expected that a foreign key exception be thrown. In real
Android, however, no exception was thrown. Only a message is printed in logcat.
Update the test to delete a row that has a reference to another table. This
causes an exception in both real Android and Robolectric. Move this to a
ctesque test to ensure fidelity with real Android.