Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider bundling helm-git and helm-s3 into the helmfile docker image #436

Closed
mumoshu opened this issue Jan 17, 2019 · 1 comment · Fixed by #651
Closed

Consider bundling helm-git and helm-s3 into the helmfile docker image #436

mumoshu opened this issue Jan 17, 2019 · 1 comment · Fixed by #651

Comments

@mumoshu
Copy link
Collaborator

mumoshu commented Jan 17, 2019

#220 #435
@mumoshu mumoshu changed the title Consider bundling helm-git and helm-s3 into your helmfile docker image? Consider bundling helm-git and helm-s3 into your helmfile docker image Jan 17, 2019
@osterman osterman mentioned this issue Jan 17, 2019
Closed
@osterman
Copy link
Contributor

@mumoshu makes sense to me.

Our strategy is to ship a few core helm-plugins in cloudposse/geodesic along with helmfile.

@mumoshu mumoshu changed the title Consider bundling helm-git and helm-s3 into your helmfile docker image Consider bundling helm-git and helm-s3 into the helmfile docker image Jan 17, 2019
mumoshu added a commit that referenced this issue Jun 4, 2019
@mumoshu
feat: bundle helm-s3 and helm-git into container images
06ce39d 
Resolves #435 (Git as chart repository)
Resolves #220 (S3 as chart repository)
Resolves #436 (About bundling helm plugins)

A lot of thanks to @aslafy-z for authoring the awesome helm-git plugin and contributing it to the community!
@mumoshu mumoshu mentioned this issue Jun 4, 2019
Merged
mumoshu added a commit that referenced this issue Jun 4, 2019
@mumoshu
feat: bundle helm-s3 and helm-git into container images (#651)
2e57beb 
Resolves #435 (Git as chart repository)
Resolves #220 (S3 as chart repository)
Resolves #436 (About bundling helm plugins)

A lot of thanks to @aslafy-z for authoring the awesome helm-git plugin and contributing it to the community!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: bundle helm-s3 and helm-git into container images roboll/helmfile
2 participants
@mumoshu @osterman