Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cache path issue on Windows #1846

Merged
merged 1 commit into from
May 13, 2021
Merged

cache path issue on Windows #1846

merged 1 commit into from
May 13, 2021

Conversation

itscaro
Copy link
Contributor

@itscaro itscaro commented May 12, 2021

v0.139.3

err: [release "pinpoint": fetching "git::https://github.com/pinpoint-apm/pinpoint-kubernetes.git@pinpoint?ref=master": get: error downloading 'https://github.com/pinpoint-apm/pinpoint-kubernetes.git?ref=master': CreateFile .helmfile\cache\pinpoint\git::https:\github.com\pinpoint-apm\pinpoint-kubernetes.git@pinpoint?ref=master\https_github_com_pinpoint-apm_pinpoint-kubernetes_git.ref=master: The filename, directory name, or volume label syntax is incorrect.; CreateFile .helmfile\cache\pinpoint\git::https:\github.com\pinpoint-apm\pinpoint-kubernetes.git@pinpoint?ref=master\https_github_com_pinpoint-apm_pinpoint-kubernetes_git.ref=master: The filename, directory name, or volume label syntax is incorrect.]
...
Path error in windows

Cache dir: .helmfile\cache\pinpoint\git::https:\github.com\pinpoint-apm\pinpoint-kubernetes.git@pinpoint?ref=master\https_github_com_pinpoint-apm_pinpoint-kubernetes_git.ref=master

Tried to sanitized chart URL with [^a-z0-9_-] => _

fatal: cannot write keep file 'E:/Data/workspace/github/helmfile/.test/.helmfile/cache/pinpoint/git__https___github_com_pinpoint-apm_pinpoint-kubernetes_git_pinpoint_ref_master/https_github_com_pinpoint-apm_pinpoint-kubernetes_git.ref=master/.git/objects/pack/pack-87115c11c9b9fd3824f439ab8ecb1ae9ba8a6d69.keep'
...
Path is too long on windows

Cache dir: .helmfile/cache/pinpoint/git__https___github_com_pinpoint-apm_pinpoint-kubernetes_git_pinpoint_ref_master/https_github_com_pinpoint-apm_pinpoint-kubernetes_git.ref=master

So I tried to remove the r.Chart in the path, maybe it's redundant?
PR will give this cache dir: .helmfile/cache/pinpoint/https_github_com_pinpoint-apm_pinpoint-kubernetes_git.ref=master

@itscaro itscaro changed the title cache path issue cache path issue on Windows May 12, 2021
Copy link
Collaborator

@mumoshu mumoshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks a lot for finding and fixing this @itscaro ☺️

@mumoshu mumoshu merged commit f38958d into roboll:master May 13, 2021
@itscaro itscaro deleted the cache-path-issue branch May 13, 2021 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants