-
Notifications
You must be signed in to change notification settings - Fork 4
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Throw an error instead of partially implementing it.
- Loading branch information
Showing
2 changed files
with
15 additions
and
15 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -81,9 +81,12 @@ namespace roboptim | |
} | ||
} | ||
|
||
static void applyDiff(const FunctionOnManifold<U>* instance) | ||
static void applyDiff(const FunctionOnManifold<U>*) | ||
{ | ||
instance->tangentMappedJacobian = instance->mappedJacobian_; | ||
// The throw will need to be replaced by something useful once the Sparse | ||
// support is ready in libmanifolds. | ||
|
||
throw std::string("No Sparse support for non RealSpaces manifolds"); | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
bchretien
Member
|
||
} | ||
}; | ||
} // end of namespace roboptim | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wait.. 3 things:
std::string
! Exceptions are here for a reason.std::string
!