Fixed interval computing + tests to validate it #29
Conversation
| if (t == knots_[static_cast<size_t>(imax+1)]) //We are exactly at the end of the spline | ||
| { | ||
| return imax; | ||
| } |
There was a problem hiding this comment.
If you confirm that this only concerns the non-uniform case, this should be move inside the dichotomy block.
There was a problem hiding this comment.
Ok.
It does not concern the uniform case. All knots-defined splines (Splines one creates with a knot vector) are concerned, even the uniform ones, but I think it indeed should be placed in the dichotomy block, as it is basically here to avoid the endless case at the end of it.
fdarricau
force-pushed
the
master
branch
2 times, most recently
from
2519003
to
9a5e61b
Compare
| if (t == knots_[static_cast<size_t>(imax+1)]) //We are exactly at the end of the spline | ||
| { | ||
| return imax; | ||
| } |
There was a problem hiding this comment.
If the problem only concerns t = t_max, this check should not be in the inner while loop either, since this will be checked at every iteration of the dichotomy.
There was a problem hiding this comment.
Sorry about that. I intended to put it out of the loop.
I fix it right now.
Fixed interval computing + tests to validate it
The loop in CubicBSpline::interval would never stop when t is on the end of the time interval.