Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update signaling decoders to print logs via boost info log instead of plain stdout #759

Merged
merged 2 commits into from
Jan 14, 2023

Conversation

EricTendian
Copy link
Contributor

I noticed that the signaling decoders were printing out decoded signals to stdout, instead of via a BOOST_LOG_TRIVIAL call. This can get pretty noisy if there's a lot of transmissions being decoded. By using the info log, someone can set a different loglevel to exclude them.

This changes the logs from:

{"type":"MDC1200","timestamp":"1672355479","op":"01","arg":"00","unitID":"5bad","ex0":"00","ex1":"00","ex2":"00","ex3":"00"}

to:

[2022-12-29 23:11:19.361464] (info)   {"type":"MDC1200","timestamp":"1672355479","op":"01","arg":"00","unitID":"5bad","ex0":"00","ex1":"00","ex2":"00","ex3":"00"}

Besides this change, I also added curl to the Dockerfile since it can be useful for upload scripts that need to call APIs (and there's no other http client currently present).

@robotastic
Copy link
Owner

Good catch! It also looks like this should address #762

@robotastic robotastic merged commit 457fe2f into robotastic:master Jan 14, 2023
@EricTendian EricTendian deleted the fixing-logging branch January 15, 2023 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants