Fix channel CSV parsing, allow for freqs in MHz, other config parsing fixes #857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EricTendian
changed the title
Merged
|
Rolled into #862 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like there was a copy-paste error in the new talkgroup/channel CSV parsing, so the channel CSV was incorrectly expecting a Decimal column header. This fixes it to the right column header.
Additionally, the new logic expects a float for frequency, which is backwards-incompatible with the frequencies in existing CSVs. To work around this, while also supporting the RadioReference format of MHz freqs, it will instead check if it's either an int or a float, and if it's a float (and under 1000), will convert the MHz frequency to Hz.
Third, the config parser expected the system IDs for Boadcastify and Rdio Uploader to be strings when they really should be ints (and were previously). This updates the actual data types to be int, so there are no type issues.