Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tox == 3.0 dependency #25

Closed
tysonite opened this issue Nov 14, 2019 · 1 comment
Closed

Tox == 3.0 dependency #25

tysonite opened this issue Nov 14, 2019 · 1 comment

Comments

@tysonite
Copy link

tysonite commented Nov 14, 2019 •
edited
Loading

Would it be possible to either remove dependency on specific version of tox, or make it less strict (e.g. >=) ?

robotframework-jsonlibrary/setup.py

Line 17 in b834e5d

'tox==3.0.0',

Now, if newer version of tox is installed in environment, pip install robotframework-jsonlibrary reverts it to this particular version, and this looks confusing and incorrect. Morever, no dependency in python code present for tox.
tysonite added a commit to tysonite/robotframework-jsonlibrary that referenced this issue Feb 18, 2021
@tysonite
Remove tox and coverage from library dependencies
39da989 
It looks like the library does not use functionality
of tox or coverage packages. Therefore, no need to specify
them in setup.py. However, they are present in requirements.txt,
so this shall be enough.

Fixes robotframework-thailand#25.
@tysonite tysonite mentioned this issue Feb 18, 2021
Closed
@tysonite
Copy link
Author

I appreciate if a new version of the library with a fix above will be released to pypi, so no conflicts with existing environments during installation.

elrandira pushed a commit to elrandira/robotframework-jsonlibrary that referenced this issue May 4, 2022
issue robotframework-thailand#25
6bee994
@elrandira elrandira mentioned this issue May 4, 2022
Merged
elrandira added a commit that referenced this issue May 9, 2022
@elrandira
Merge pull request #35 from elrandira/master
67e1c9e 
Fixes for #5, #6, #25, #26, #29, #30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove tox and coverage from library dependencies tysonite/robotframework-jsonlibrary
2 participants
@tysonite @elrandira