Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for #5, #6, #25, #26, #29, #30 #35

Merged
merged 9 commits into from
May 9, 2022

Conversation

elrandira
Copy link
Collaborator

@elrandira elrandira commented May 4, 2022

This is my proposal to merge existing pull request

And solves the following issues:

Add new keywords:

If you agree with these changes, thanks to accepts the pull request and update the delivery on Pypi

@pencherek
Copy link
Collaborator

Ok, good idea, just how do I do that, I don't really know how to do that on github

@elrandira
Copy link
Collaborator Author

Hi, only the repo owner and the approved contributors can accept a pull request. Buttons should be visible to them.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/approving-a-pull-request-with-required-reviews

@pencherek
Copy link
Collaborator

I think the owner droped it, the repo got any update for year and in the issue (bug) page, he has not posted for a long time

@pencherek
Copy link
Collaborator

Perhaps we sould create a new repository and a new entry for pip on Pypi

@elrandira
Copy link
Collaborator Author

elrandira commented May 9, 2022

Yes that came to my mind, I'll look into it. In the meantime, my branch can be used by anyone:

git install git+https://github.com/elrandira/robotframework-jsonlibrary

@pencherek
Copy link
Collaborator

So your branch is the most updated ?
If so I have a idea for a update for the "Get Value From Json" keyword,
we will need perhaps to use a better JSONPATH interpreter, during my work with robot framework, some complex JSONPATH were not working as expected

@nottyo
Copy link
Collaborator

nottyo commented May 9, 2022

@elrandira I'm sorry to for my late reply. I'm not working for this project anymore. However, I'll add you to be one the owner of this repository so that you can manage changes from now on.

@elrandira
Copy link
Collaborator Author

elrandira commented May 9, 2022

Thanks @nottyo, I'll look into it :)

@pencherek, eventually you can open an issue to keep track on your idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants