Remove deprecated headless option for chrome and firefox. #1858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emanlove
reviewed
Oct 12, 2023
emanlove
reviewed
Oct 12, 2023
|
@trauty-is-me Thanks for this pull request. I've made a couple of suggestions/corrections on the code. Let me know if you see anything I am missing. I will schedule this for the next release v6.2.0. Thanks again and have a great day! |
|
Happy to make the changes, I won't be in a position to make the changes and test for a couple of days as I am away without my computer. |
trauty-is-me
force-pushed
the
fix_headless_args
branch
2 times, most recently
from
b8c276b
to
65e3c2a
Compare
Deprecated in Version 4.8.0 of Selenium Removed in version 4.13.0
trauty-is-me
force-pushed
the
fix_headless_args
branch
from
65e3c2a
to
87693af
Compare
emanlove
added
bug
priority: critical
acknowledge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecated in Version 4.8.0 of Selenium
Removed in version 4.13.0