Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated headless option for chrome and firefox. #1858

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Remove deprecated headless option for chrome and firefox. #1858

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/SeleniumLibrary/keywords/webdrivertools/webdrivertools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ def create_headless_chrome(
):
if not options:
options = webdriver.ChromeOptions()
options.headless = True
options.add_argument('--headless=new')
return self.create_chrome(
desired_capabilities, remote_url, options, service_log_path, executable_path
)
Expand Down Expand Up @@ -224,7 +224,7 @@ def _get_ff_profile(self, ff_profile_dir):
else:
setattr(ff_profile, key, *option[key])
return ff_profile

@property
def _geckodriver_log(self):
log_file = self._get_log_path(
Expand All @@ -244,7 +244,7 @@ def create_headless_firefox(
):
if not options:
options = webdriver.FirefoxOptions()
options.headless = True
options.add_argument('-headless')
return self.create_firefox(
desired_capabilities,
remote_url,
Expand Down