Fixed compatibility with RobotFramework v2.8 #212
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 12, 2013 16:11
…y with RobotFramework v2.8. Fixed keyword.async_javascripts test.
…abulation in async_javascript test.
|
Sorry for breaking backwards-compatibility with the change to ConnectionCache.current_index. I'll make it an assignable property to fix the issue on Robot side in 2.8.1: Changing this in Se2Lib is probably a good idea too. It seems that Selenium2Library doesn't actually use current_index for anything, and ConnectionCache never reads it either, so the simplest fix is removing |
|
Fixed in #251 (without unnecessary changes async_javascript tests.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed unnecessary assignment of self.current_index for compatibility with RobotFramework v2.8, in new robot version current_index is a property without setter.
You don't need to take care about None in current_index anymore if this will be true "self.current is self._no_current" it will return None by default.
Also fixed keyword.async_javascripts test for 100% passing rate.