Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestRunnerAgent: Fall back to pickle if JSON fails #1662

Merged
merged 1 commit into from Sep 8, 2019
Merged

TestRunnerAgent: Fall back to pickle if JSON fails #1662

merged 1 commit into from Sep 8, 2019

Conversation

edbrannin
Copy link
Contributor

Fixes #1661

@HelioGuilherme66
Copy link
Member

HelioGuilherme66 commented Jan 19, 2019 •
edited

@edbrannin Hi,
We now have a newer functional version of RIDE for Python 2.7 and 3.6+. We kept it running on MacOS, Linux and Windows. Are you still interested in RIDE? If so, please update your fork, and keep finding bugs and contributing with code.

This PR, does not look to cause any problems, but it needs to be tested in different OSes and situations. As it seems that we could not reproduce #1661, would you please review this PR? Thanks.

@HelioGuilherme66 HelioGuilherme66 added this to the v1.7.4 milestone Sep 8, 2019
@HelioGuilherme66 HelioGuilherme66 added the enhancement Request for improvement: either for an existing feature or a new one label Sep 8, 2019
@HelioGuilherme66
Copy link
Member

@edbrannin It is now almost 3 years after this PR being created. The change looks safe and probably would not be ever noticed. Unit tests pass with current RF 3.1.2, so it is accepted.

@HelioGuilherme66 HelioGuilherme66 merged commit e891dfd into robotframework:master Sep 8, 2019
@edbrannin
Copy link
Contributor Author

Thanks! Sorry I didn't respond earlier -- since creating this PR I've moved to a different company that's not using Robot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement Request for improvement: either for an existing feature or a new one
Projects
None yet
Milestone
v1.7.4
Development

Successfully merging this pull request may close these issues.

TestRunnerAgent: "TypeError: <...> is not JSON serializable" when register_run_keyword is not used
2 participants
@edbrannin @HelioGuilherme66