Skip to content

Commit

Permalink
f-strings
Browse files Browse the repository at this point in the history
  • Loading branch information
pekkaklarck committed Aug 16, 2022
1 parent 800e7e6 commit cb45caf
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 9 deletions.
3 changes: 1 addition & 2 deletions src/robot/running/builder/parsers.py
Original file line number Diff line number Diff line change
Expand Up @@ -142,5 +142,4 @@ def visit_Error(self, node):
LOGGER.error(self._format_message(error))

def _format_message(self, token):
return ("Error in file '%s' on line %s: %s"
% (self.source, token.lineno, token.error))
return f"Error in file '{self.source}' on line {token.lineno}: {token.error}"
14 changes: 7 additions & 7 deletions src/robot/running/model.py
Original file line number Diff line number Diff line change
Expand Up @@ -419,9 +419,9 @@ def __init__(self, name, value, source=None, lineno=None, error=None):

def report_invalid_syntax(self, message, level='ERROR'):
source = self.source or '<unknown>'
line = ' on line %s' % self.lineno if self.lineno is not None else ''
LOGGER.write("Error in file '%s'%s: Setting variable '%s' failed: %s"
% (source, line, self.name, message), level)
line = f' on line {self.lineno}' if self.lineno else ''
LOGGER.write(f"Error in file '{source}'{line}: "
f"Setting variable '{self.name}' failed: {message}", level)


class ResourceFile:
Expand Down Expand Up @@ -502,8 +502,8 @@ class Import:

def __init__(self, type, name, args=(), alias=None, source=None, lineno=None):
if type not in self.ALLOWED_TYPES:
raise ValueError("Invalid import type '%s'. Should be one of %s."
% (type, seq2str(self.ALLOWED_TYPES, lastsep=' or ')))
raise ValueError(f"Invalid import type '{type}'. Should be one of "
f"{seq2str(self.ALLOWED_TYPES, lastsep=' or ')}.")
self.type = type
self.name = name
self.args = args
Expand All @@ -521,8 +521,8 @@ def directory(self):

def report_invalid_syntax(self, message, level='ERROR'):
source = self.source or '<unknown>'
line = ' on line %s' % self.lineno if self.lineno is not None else ''
LOGGER.write("Error in file '%s'%s: %s" % (source, line, message), level)
line = f' on line {self.lineno}' if self.lineno else ''
LOGGER.write(f"Error in file '{source}'{line}: {message}", level)


class Imports(model.ItemList):
Expand Down

0 comments on commit cb45caf

Please sign in to comment.