Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate --monitorxxx options in favor of --consolexxx #2027

Closed
pekkaklarck opened this issue Jun 16, 2015 · 1 comment
Closed

Deprecate --monitorxxx options in favor of --consolexxx #2027

pekkaklarck opened this issue Jun 16, 2015 · 1 comment
Assignees
@pekkaklarck
Labels
alpha 3 deprecation enhancement priority: medium
Milestone
2.9

Comments

@pekkaklarck
Copy link
Member

Options --monitorcolors, --monitorwidth and --monitormarkers are badly named. They affect how execution is reported on the console and should be called --consolecolors, --consolewidth and --consolemarkers instead. This is especially important when we added new --console option (#317) to control the overall console output style.

The change is backwards incompatible and thus we cannot just remove the old options but need to deprecate them first. We can keep old short options -C, -W and -K to ease transition to new options.
@pekkaklarck pekkaklarck self-assigned this Jun 16, 2015
@pekkaklarck pekkaklarck added this to the 2.9 milestone Jun 16, 2015
@pekkaklarck pekkaklarck mentioned this issue Jun 16, 2015
Closed
@pekkaklarck pekkaklarck changed the title Deprecate --monitorxxx options in favor of --consolexxx options Deprecate --monitorxxx options in favor of --consolexxx Jun 16, 2015
pekkaklarck added a commit that referenced this issue Jun 16, 2015
@pekkaklarck
Added new --consolexxx options to replace --monitorxxx optoins #2027.
657eb3f 
Old options aren't deprecated yet. All old tests pass with these changes
which means old options still work as earlier.
pekkaklarck added a commit that referenced this issue Jun 16, 2015
@pekkaklarck
Atests now use --consolexxx options instead of --monitorxxx.
6105d29 
Also updated terminology to use console instead of monitor in test and
resource names. #2027
pekkaklarck added a commit that referenced this issue Jun 16, 2015
@pekkaklarck
Deprecated --monitorxxx options in favor of --consolexxx #2027
010f75f
pekkaklarck added a commit that referenced this issue Jun 16, 2015
@pekkaklarck
User Guide: --monitorxxx options are deprecated in favor of --console…
b5ed539 
…xxx #2027
@pekkaklarck
Copy link
Member Author

Implemented, tested, and documented.

@pekkaklarck pekkaklarck mentioned this issue Nov 11, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pekkaklarck pekkaklarck

Labels
alpha 3 deprecation enhancement priority: medium
Projects
None yet
Milestone
2.9
Development

No branches or pull requests
1 participant
@pekkaklarck