Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate escaping leading empty cells with \ #3148

Closed
pekkaklarck opened this issue Apr 10, 2019 · 1 comment
Closed

Deprecate escaping leading empty cells with \ #3148

pekkaklarck opened this issue Apr 10, 2019 · 1 comment

Comments

@pekkaklarck
Copy link
Member

When deprecating ignoring lines with only ... (#3107) noticed that this strange syntax is currently supported:

*** Settings ***
Documentation    WTF
\    ...    ?
\    \    ...    ?

*** Test Cases ***
Example
    Log Many    one    two
    \    ...    three
    \    \    \    \    \    ...    four

The example above would work exactly the same way if all \ characters and optionally spaces after them were removed. My guess is that we used to support ... not only in the first column when using HTML/TSV formats and in the plain text format \ is used to escape empty cells.

This escaping syntax brings no benefits and makes no sense in general. The new parser (#3076) won't support it anymore and thus we need to deprecate it in RF 3.1.2. Luckily I expect nobody to use this strange syntax.

@pekkaklarck pekkaklarck added this to the v3.1.2 milestone Apr 10, 2019
pekkaklarck added a commit that referenced this issue Apr 10, 2019
Also avoid unnecessary usage of escaping leading empty cells to
ease deprecating it. See #3148.
@pekkaklarck
Copy link
Member Author

This was somewhat hard to deprecate because \ is also used for escaping leading empty cells with for loops. That syntax will be deprecated in RF 3.2 in favor of closing for loops explicitly with END (#3078), but we don't want to emit warnings in RF 3.1.2 yet.

In the end decided to deprecate escaping leading empty cells only when used before .... That covers both of the usages in the original description and elsewhere leading \ ought to be an error already now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant