Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support dark theme with report and log #3725

Closed
KotlinIsland opened this issue Oct 20, 2020 · 4 comments
Closed

Support dark theme with report and log #3725

KotlinIsland opened this issue Oct 20, 2020 · 4 comments
Assignees
@Snooz82
Labels
acknowledge To be acknowledged in release notes effort: medium enhancement priority: high rc 1
Milestone
v7.0

Comments

@KotlinIsland
Copy link
Contributor

No description provided.

@pekkaklarck
Copy link
Member

Do you have concrete examples how it should look like? Are you interested to help with development?

@psaikkonen
Copy link
Contributor

Opened a draft PR regarding this: #4190

@pekkaklarck pekkaklarck added this to the v7.0 milestone Dec 20, 2023
@pekkaklarck
Copy link
Member

PR #4190 seems to be in such a good shape that we'll get dark mode already in RF 7.0. Thanks for contribution @psaikkonen already now and thanks also for @Snooz82 who promised review/finalize the PR.

@pekkaklarck pekkaklarck changed the title Support dark theme for report Support dark theme with report and log Dec 20, 2023
pekkaklarck pushed a commit that referenced this issue Dec 21, 2023
@Snooz82
implemented dark_light theme toggle button (#4990)
b3ce554 
Part of #3725.

Signed-off-by: René <snooz@posteo.de>
pekkaklarck added a commit that referenced this issue Dec 21, 2023
@pekkaklarck
Fine-tune dark mode toggling in report and log.
113cdf2 
Store the theme to `localStorage` using our existing `storage`
functionality. It's more consistent than accessing `localStorage`
directly and our code also handles the situation where `localStorage`
is not available.

Related to issue #3725 and PR #4990.
pekkaklarck added a commit that referenced this issue Dec 21, 2023
@pekkaklarck
Report/log: Move theme toggle to bottom right corner.
7dcfc9f 
Also remove unused debug code.

Related to issue #3725 and PR #4990.
@pekkaklarck
Copy link
Member

There has been some style changes related to the theme toggle button, but now this feature is in good enough shape to be considered ready. Styles can still be fine-tuned after the release candidate is out.

pekkaklarck added a commit that referenced this issue Jan 2, 2024
@pekkaklarck
Less bright white text in report/log dark mode. #3725
5633a3f 
We use this color also with Libdoc that has had the dark mode for a
longer time.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Snooz82 Snooz82

Labels
acknowledge To be acknowledged in release notes effort: medium enhancement priority: high rc 1
Projects
None yet
Milestone
v7.0
Development

No branches or pull requests
4 participants
@pekkaklarck @psaikkonen @Snooz82 @KotlinIsland