Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not exclude files during parsing if using --suite option #4688

Closed
pekkaklarck opened this issue Mar 14, 2023 · 1 comment
Closed

Do not exclude files during parsing if using --suite option #4688

pekkaklarck opened this issue Mar 14, 2023 · 1 comment

Comments

@pekkaklarck
Copy link
Member

pekkaklarck commented Mar 14, 2023

Currently when the --suite option is used, files not matching the specified suite aren't parsed at all. This is a useful performance optimization, but it doesn't work well with the new Name setting (#4583) that allows configuring the suite name in the parsed file itself. In addition to that, suites not being parsed and not thus not being available for pre-run modifiers can cause surprises. To avoid all these issues, it is better to not use --suite for limiting what files are parsed at all.

This change isn't functionally backwards incompatible, but it obviously affects those who --suite to make parsing faster. A precondition to such a change is having an explicit way to limit what files are parsed (#4687).

@pekkaklarck pekkaklarck added this to the v7.0 milestone Mar 14, 2023
@pekkaklarck pekkaklarck changed the title Do not exclude filles if using --suite option Do not exclude files if using --suite option Mar 14, 2023
pekkaklarck added a commit that referenced this issue Apr 5, 2023
- Explain their usage and how they work together better.
- Explain that new Name is not compatible with --suite (#4583)
- Explain how --suite is going to be changed (incl. fixing of the
  above issue) in RF 7.0 (#4720, #4721, #4688)
@pekkaklarck pekkaklarck modified the milestones: v7.0, v6.1 May 17, 2023
@pekkaklarck
Copy link
Member Author

pekkaklarck commented May 17, 2023

Several things have changed after I submitted this issue:

Due to the above changes, I believe it is best to make this change already in RF 6.1. It would be stupid to make a release where --suite doesn't work reliably, and those who depend on its current performance enhancement will have an alternative available.

@pekkaklarck pekkaklarck changed the title Do not exclude files if using --suite option Do not exclude files during parsing if using --suite option May 23, 2023
pekkaklarck added a commit that referenced this issue Jun 11, 2023
The --suite option doesn't anymore affect what files are parsed
(#4688), so there's no incompatibility with it and the new Name
setting.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant