Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance performance of visiting parsing model #4934

Closed
pekkaklarck opened this issue Nov 7, 2023 · 1 comment
Closed

Enhance performance of visiting parsing model #4934

pekkaklarck opened this issue Nov 7, 2023 · 1 comment
Labels
Milestone

Comments

@pekkaklarck
Copy link
Member

When Robot parses data files, it produces a model that both Robot itself and external tools use. Going through the model is easiest by using visitors. That is typically pretty fast, but it is possible to enhance the performance, for example, by caching visitor methods. These enhancements are especially important for external tools such as editor plugins that need to process lot of data.

We already have PR #4911 by @d-biehl that adds visitor method caching. This issue exists mainly for tracking purposes, but it also covers mentioning caching in visitor documentation. Possible additional performance enhancements can be linked to this same issue as well.

@pekkaklarck
Copy link
Member Author

I just noticed that we actually use ast.NodeVisitor directly, not our own ´ModelVisitor, when transforming parsing models to running models. That obviously means that performance enhancements to ModelVisitor` cannot have any effect to parsing. I'll fix that.

pekkaklarck added a commit that referenced this issue Nov 13, 2023
This way performance enhancements to ModelVisitor (#4934) get to use
also when using Robot itself.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant