You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Listeners have methods like output_file and log_file that are called when result files are ready. At the moment they get the path to the file as a string, but I believe with listener v3 methods we should use pathlib.Path instead. Path instances are more convenient to use and we are now enhancing v3 listeners also otherwise.
This change is backwards incompatible, but in most cases str and Path work the same way, so it's unlikely that the change causes big problems. For example, our acceptance tests passed after I changed the type locally and I needed to add special checks to make sure the received path is actually Path.
Although the change is pretty safe, with listener v2 it's anyway safer to keep using str. We are also otherwise just using base types with them.
The text was updated successfully, but these errors were encountered:
Listeners have methods like
output_file
andlog_file
that are called when result files are ready. At the moment they get the path to the file as a string, but I believe with listener v3 methods we should use pathlib.Path instead.Path
instances are more convenient to use and we are now enhancing v3 listeners also otherwise.This change is backwards incompatible, but in most cases
str
andPath
work the same way, so it's unlikely that the change causes big problems. For example, our acceptance tests passed after I changed the type locally and I needed to add special checks to make sure the received path is actuallyPath
.Although the change is pretty safe, with listener v2 it's anyway safer to keep using
str
. We are also otherwise just using base types with them.The text was updated successfully, but these errors were encountered: