Issue #3579: Incomplete draft of a solution #3580
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Employ memoization to speed up tag filtering. - This is a first draft. - Unit tests not edited at all. - Not sure about storing to self._memo everywhere. - Not sure if normalization is applied everywhere needed. + Normalization applied in most places. + Memo dictionary is passed from callers, created empty if needed. + Memo dictionary uses normalized pattern or tag as the key. + Multiple copies of the same pattern for SingleTagPattern do not duplicate matchers. + Each such matcher has memo dictionary to store (normalized) tag match results. + Calls to the same matcher with the same tag return the memoized result. - Matcher memo should probably have different name than result memo. Signed-off-by: Vratko Polak <vrpolak@cisco.com>
Codecov Report
@@ Coverage Diff @@
## master #3580 +/- ##
===========================================
- Coverage 74.21% 24.73% -49.48%
===========================================
Files 199 54 -145
Lines 16466 3847 -12619
Branches 2653 697 -1956
===========================================
- Hits 12218 951 -11267
+ Misses 3817 2871 -946
+ Partials 431 25 -406
Continue to review full report at Codecov.
|
|
Based on the comment in #3579 this attempt didn't work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Employ memoization to speed up tag filtering.
Signed-off-by: Vratko Polak vrpolak@cisco.com