Roshue repo #8
Merged
Roshue repo #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, awesome! |
| package_dir={'': 'src'}, | ||
| scripts=['scripts'], | ||
| scripts=['scripts/rocon_hue_bridge.py'], |
There was a problem hiding this comment.
It would be better to keep this as a local executable.
Remove this global script installation and add install rule in CMakeLists.txt by following
install(
PROGRAMS
scripts/rocon_hue_bridge.py
DESTINATION ${CATKIN_PACKAGE_BIN_DESTINATION}
)
There was a problem hiding this comment.
+1
Convention is that nodes to be used in launchers with configurable parameters should always be local.
There was a problem hiding this comment.
Open a new ticket for fixing this?
There was a problem hiding this comment.
It has fixed by this 5bf9841
jihoonl
added a commit
that referenced
this pull request
Apr 13, 2014
Well. Merging this. I will fix the minor issues.
jihoonl
added a commit
that referenced
this pull request
Apr 13, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release preparation works
#4