Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICartesianSolver getNumLinks to getNumJoints #98

Closed
jgvictores opened this issue May 6, 2017 · 2 comments
Closed

ICartesianSolver getNumLinks to getNumJoints #98

jgvictores opened this issue May 6, 2017 · 2 comments
Assignees
@jgvictores

Comments

@jgvictores
Copy link
Member

ICartesianSolver getNumLinks to getNumJoints
@jgvictores jgvictores self-assigned this May 6, 2017
@jgvictores
Copy link
Member Author

WIP at 21ec3ea (fix-98-get-joints branch).

@jgvictores jgvictores mentioned this issue Jun 5, 2017
Closed
jgvictores added a commit that referenced this issue Jun 13, 2017
@jgvictores
prepend ROBOTICSLAB_KINEMATICS_DYNAMICS_DEPRECATED
6adaac9 
prepend ROBOTICSLAB_KINEMATICS_DYNAMICS_DEPRECATED to old getNumLinks
- roboticslab-uc3m/questions-and-answers#21
- #98
jgvictores added a commit that referenced this issue Jun 13, 2017
@jgvictores
Merge 'qa-21-deprecated' into fix-98-get-joints
e059098 
- roboticslab-uc3m/questions-and-answers#21
- #98
jgvictores added a commit that referenced this issue Jun 13, 2017
@jgvictores
Merge branch 'fix-98-get-joints' into develop, #98
0d9d173
@jgvictores
Copy link
Member Author

Done at 0d9d173, see roboticslab-uc3m/questions-and-answers#21 for discussions on implementation.

PeterBowman added a commit that referenced this issue Jun 15, 2017
@PeterBowman
Rename getNumLinks to getNumJoints per #98
e0786d2
PeterBowman added a commit that referenced this issue Aug 29, 2017
@PeterBowman
Make ICartesianSolver::getNumLinks call getNumJoints
106aff2 
It doesn't really make sense to let this method suddenly break legacy
code - we wouldn't mess then with deprecation notices, just remove it
straight away. Apart from that, our own kin-dyn codebase doesn't check
the return value, thus subtle bugs may be introduced. By now, it feels
more appropriate to enable downstreams to call getNumLinks with no
further harm, but preserve the warning so that users and maintainers may
notice this and update their code.

Related issues:

* #98
* roboticslab-uc3m/questions-and-answers#21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jgvictores jgvictores

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jgvictores